Compiler Installation Ubuntu 24 fix #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rakesh <153008248+RakeshwarK@users.noreply.github.com>
|
LGTM. Please document the testing done for this bug fix. |
alexffrank
approved these changes
Jun 28, 2024
src/VirtualClient/VirtualClient.Dependencies.UnitTests/CompilerInstallationTests.cs
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Dependencies.UnitTests/CompilerInstallationTests.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Dependencies.UnitTests/CompilerInstallationTests.cs
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Dependencies/CompilerInstallation.cs
Outdated
Show resolved
Hide resolved
|
The compiler installation is being used by multiple workloads in Linux, can we test the workloads like STREAM, SpecCpu, etc where this is used, with appropriate Linux versions, to make sure that backward compatibility is maintained. |
|
I have tested this with 3 workloads on X64 ubuntu (24,22,20) and Arm Ubuntu (24, 22). |
brdeyo
approved these changes
Jul 3, 2024
|
Merging changes to address compiler installation issues on Ubuntu 24.04 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove all alternatives for 'cpp' to avoid the symlink looping issue which is causing the error "too many levels of symbolic links" on Ubuntu 24.04.