Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting a specific instance of nested parameter evaluation. #348

Merged
merged 4 commits into from
Jul 26, 2024
Merged

Correcting a specific instance of nested parameter evaluation. #348

merged 4 commits into from
Jul 26, 2024

Conversation

mittaltarkik
Copy link
Contributor

While using the Turney function, I encountered an issue. If a parameter's value is used before its evaluation, it fails with the error CS1002: ; expected. This happens because we are performing both EvaluateParameterSpecificExpressions and EvaluateWellKnownExpressionsAsync in the same loop.

To resolve this, I have moved the EvaluateParameterSpecificExpressions to a separate loop, and now this case works fine.

@mittaltarkik
Copy link
Contributor Author

@mittaltarkik please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree company="Microsoft"

@nmalkapuram nmalkapuram enabled auto-merge (squash) July 26, 2024 06:56
@nmalkapuram nmalkapuram merged commit d790b30 into microsoft:main Jul 26, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants