-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature to Install NVIDIA GPU Drivers and CUDA Toolkit in Windows #87
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not seeing an example of how we are going to install it in Windows. Please add where did you get the driverInstall.exe, and how we versioned it etc. Ideally we should be getting it with wget, and with custom versions if possible.
src/VirtualClient/VirtualClient.Dependencies/CUDAAndNvidiaGPUDriverInstallation.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Dependencies/CUDAAndNvidiaGPUDriverInstallation.cs
Outdated
Show resolved
Hide resolved
d5e751c
to
9c0a714
Compare
Added examples in the documentation. Modified the code to use wget, earlier it was being downloaded using HttpClient. |
4680a21
to
16e093e
Compare
16e093e
to
379cf09
Compare
website/docs/dependencies/0031-install-cuda-and-nvidia-drivers.md
Outdated
Show resolved
Hide resolved
website/docs/dependencies/0031-install-cuda-and-nvidia-drivers.md
Outdated
Show resolved
Hide resolved
website/docs/dependencies/0031-install-cuda-and-nvidia-drivers.md
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Dependencies/Packaging/WgetPackageInstallation.cs
Outdated
Show resolved
Hide resolved
src/VirtualClient/VirtualClient.Dependencies/CUDAAndNvidiaGPUDriverInstallation.cs
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good with all the clean up. I would like to see the RebootRequired removed if possible, other wise we need to make it clear that Linux will reboot anyway, that parameter only applies to Windpws
This PR adds the feature to Install NVIDIA GPU Drivers and CUDA Toolkit in Windows:
The User can either provide the Web URL to download the drivers or download it from a blob storage using DependencyPackageInstallation followed by Installing the Drivers.