Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature to Install NVIDIA GPU Drivers and CUDA Toolkit in Windows #87

Merged
merged 13 commits into from
May 16, 2023

Conversation

imadityaa
Copy link
Contributor

This PR adds the feature to Install NVIDIA GPU Drivers and CUDA Toolkit in Windows:
The User can either provide the Web URL to download the drivers or download it from a blob storage using DependencyPackageInstallation followed by Installing the Drivers.

@imadityaa imadityaa marked this pull request as ready for review April 21, 2023 14:59
@imadityaa imadityaa requested a review from yangpanMS April 21, 2023 14:59
Copy link
Contributor

@yangpanMS yangpanMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not seeing an example of how we are going to install it in Windows. Please add where did you get the driverInstall.exe, and how we versioned it etc. Ideally we should be getting it with wget, and with custom versions if possible.

@imadityaa imadityaa force-pushed the users/adityaa/nvidiaWindows branch from d5e751c to 9c0a714 Compare April 24, 2023 11:33
@imadityaa
Copy link
Contributor Author

I'm not seeing an example of how we are going to install it in Windows. Please add where did you get the driverInstall.exe, and how we versioned it etc. Ideally we should be getting it with wget, and with custom versions if possible.

Added examples in the documentation. Modified the code to use wget, earlier it was being downloaded using HttpClient.

@imadityaa imadityaa force-pushed the users/adityaa/nvidiaWindows branch 3 times, most recently from 4680a21 to 16e093e Compare April 28, 2023 11:55
@imadityaa imadityaa force-pushed the users/adityaa/nvidiaWindows branch from 16e093e to 379cf09 Compare May 12, 2023 18:31
Copy link
Contributor

@yangpanMS yangpanMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with all the clean up. I would like to see the RebootRequired removed if possible, other wise we need to make it clear that Linux will reboot anyway, that parameter only applies to Windpws

@yangpanMS yangpanMS merged commit 9a307a6 into main May 16, 2023
@yangpanMS yangpanMS deleted the users/adityaa/nvidiaWindows branch May 16, 2023 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants