Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change CT/CG text rendering to default on DWRITE_RENDERING/MEASURING_… #1652

Closed
wants to merge 1 commit into from

Conversation

ms-jihua
Copy link
Contributor

@ms-jihua ms-jihua commented Jan 6, 2017

…MODE_GDI_NATURAL

Fixes #1594


This change is Reviewable

@ms-jihua
Copy link
Contributor Author

ms-jihua commented Jan 6, 2017

I tried a few different rendering modes. The GDI modes were the only ones that actually fixed the problem while not introducing noticeable aliasing to other test apps like iLabyrinth. Between GDI_CLASSIC and GDI_NATURAL, there was not very much noticeable difference, but GDI_NATURAL seemed to look slightly better? (very scientific)

Copy link
Contributor

@rajsesh rajsesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am convinced that this is the right approach to fix this specific bug. Our default rendering mode should be default, as that would let DWrite pick the right rendering mode. GDI, GDI natural, etc are anti-aliased in the horizontal direction, and according to the documentation large fonts will not look good (they should use the DWRITE_RENDERING_MODE_NATURAL_SYMMETRIC mode).

The issue here per our offline discussion is:

  1. App is drawing to smaller bitmap and scaling it. Without anti-aliasing, this app will look okay because it is pixelated overall, but that is not a good solution.

  2. Things like sub pixel positioning will be lost. Those are clear winners on phone (small screen devices).

@ms-jihua
Copy link
Contributor Author

We decided that this solution was not satisfactory - going to investigate another one.

@ms-jihua ms-jihua closed this Jan 31, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants