Fix CoreText test and drawing failures on ARM #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DHowett-MSFT
approved these changes
Jan 18, 2017
rajsesh
approved these changes
Jan 18, 2017
ms-jihua
approved these changes
Jan 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In a recent update to Windows it became necessary to return the identity matrix from our custom text renderer's GetCurrentTransform or a garbage value could potentially persist, incorrectly placing all line origins near 0 or INF on ARM. It also seems that, on ARM, DWrite is rounding the baselineOrigin values to the nearest integer, causing tests expecting certain values to fail.
Fixes #1597
Fixes #1673
This change is