Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove freetype library and references #1728

Closed
wants to merge 1 commit into from
Closed

Remove freetype library and references #1728

wants to merge 1 commit into from

Conversation

aballway
Copy link
Contributor

@aballway aballway commented Jan 18, 2017 •
edited by rajsesh
Loading

Fixes #1455

This change is Reviewable

@aballway aballway requested review from rajsesh and ms-jihua January 18, 2017 21:05
rajsesh
rajsesh approved these changes Jan 18, 2017
View reviewed changes
Copy link
Contributor

@rajsesh rajsesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We wont need freetype attribution anymore in the licenses.txt file in the repo root.

rajsesh
rajsesh suggested changes Jan 18, 2017
View reviewed changes
Copy link
Contributor

@rajsesh rajsesh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

freetype is also referenced in multiple projects, they need to go. also references in .gitsubmodules.

@aballway
Copy link
Contributor Author

Closing due to dependency on freetype coming from cairo, will remove freetype after CGD2D merges in and we no longer require cairo

@aballway aballway closed this Jan 19, 2017
@aballway aballway deleted the coretext branch February 15, 2017 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajsesh rajsesh rajsesh requested changes

@ms-jihua ms-jihua Awaiting requested review from ms-jihua

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aballway @rajsesh @msftclas