Update scripts for running vsimporter on all the samples #2097
Conversation
scripts/build/unzip.ps1
Outdated
| [string]$zipFile = $(throw 'Mandatory parameter "zipFile" is not set.'), | ||
| [string]$outputDir = $(throw 'Madatory parameter "outputDir" is not set.') | ||
| ) | ||
|
|
||
| $zipFile = gci $zipFile |
There was a problem hiding this comment.
Converts to absolute path (it was useful to have a * in the path)
In reply to: 103060152 [](ancestors = 103060152)
There was a problem hiding this comment.
is that the normal way? gci is usually used to get a child item of the current item.
In reply to: 103061610 [](ancestors = 103061610,103060152)
There was a problem hiding this comment.
I suppose get-item would be more correct
In reply to: 103062479 [](ancestors = 103062479,103061610,103060152)
| @@ -14,15 +15,18 @@ $ErrorActionPreference = "Stop" | |||
|
|
|||
| & $PSScriptRoot\unzip.ps1 -zipFile $zipFile -outputDir $tempDir | |||
|
|
|||
| $XCodeProjects = gci -recurse $tempDir\*.xcodeproj | |||
| $XCodeProjects = gci -recurse $PSScriptRoot\..\..\samples\*.xcodeproj | |||
| $XCodeProjects += gci -recurse $PSScriptRoot\..\..\tests\testapps\*.xcodeproj | |||
There was a problem hiding this comment.
I think we should use the more generic thing where the xcode folder is passed in. #WontFix
There was a problem hiding this comment.
Why? Then we'd have to run the script twice and so we'd unzip tools twice. At that point we should just be running vsimporter directly and not using this script at all.
In reply to: 103060288 [](ancestors = 103060288)
There was a problem hiding this comment.
I was thinking you'd pass in \build\ and let it recurse from there
In reply to: 103061909 [](ancestors = 103061909,103060288)
There was a problem hiding this comment.
..why build? There's no xcodeprojs under build.
In reply to: 103062579 [](ancestors = 103062579,103061909,103060288)
|
|
| #> | ||
| param( | ||
| #NOTE: using Parameter(Mandatory) will hang the VSO build job since powershell will block waiting for user input. | ||
| #NOTE: using Parameter(Mandatory) will hang the VSO build job since | ||
| # powershell will block waiting for user input. | ||
| [string]$zipFile = $(throw 'Mandatory parameter "zipFile" is not set.'), |
There was a problem hiding this comment.
I'm not sure what the build def looks like, but, do we need to do this at all? I thought we don't have a zip file anymore.
There was a problem hiding this comment.
We will need to "install" the tools package. I thought it would be better for build isolation to not actually install it and instead just unzip the package and run vsimporter from the unzipped package
There was a problem hiding this comment.
If and when we move vsimporter into the VSIX for "new project" support, well need to come up with a way to test that in isolation. Not sure what that will look like.
|
|
These changes are needed for packaging's CI builds