Skip to content

Commit

Permalink
Update SignalSection: "System / Critical" and IsClosable="False" (#1532)
Browse files Browse the repository at this point in the history
## Description

- Updated text to match content: "System / Critical Background". Fixing
a typo.
- Also set **IsClosable="False**" on the InfoBar, because when it's
closed, user needs to nav to the page again to see it.

## Motivation and Context

Incorrect text.
Illogical use case for InfoBar.

## Screenshots (if appropriate):

![image](https://github.com/microsoft/WinUI-Gallery/assets/65828559/51edb52b-ffcd-4f1d-b186-27c1483f4d4b)![image](https://github.com/microsoft/WinUI-Gallery/assets/65828559/1a4a942c-a33d-4cd7-b82b-3cc4325ea568)

## Types of changes

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
  • Loading branch information
Jay-o-Way authored and karkarl committed Jul 15, 2024
1 parent df971e1 commit 877f21e
Showing 1 changed file with 8 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
Description="Used for accent fills on controls">
<InfoBar
Title="Title"
IsClosable="False"
IsOpen="True"
Message="This is body text. Windows 11 is faster and more intuitive."
Severity="Error" />
Expand All @@ -30,7 +31,7 @@
<ColumnDefinition Width="*" />
<ColumnDefinition Width="*" />
</Grid.ColumnDefinitions>

<designguidance:ColorTile
Background="{ThemeResource SystemFillColorSuccessBrush}"
ColorBrushName="SystemFillColorSuccessBrush"
Expand All @@ -49,8 +50,8 @@
Foreground="{ThemeResource TextFillColorInverseBrush}"
ShowSeparator="False" />
<designguidance:ColorTile
Background="{ThemeResource SystemFillColorCriticalBrush}"
Grid.Column="2"
Background="{ThemeResource SystemFillColorCriticalBrush}"
ColorBrushName="SystemFillColorCriticalBrush"
ColorExplanation="Badge"
ColorName="System / Critical"
Expand All @@ -64,7 +65,7 @@
<ColumnDefinition Width="*" />
<ColumnDefinition Width="*" />
</Grid.ColumnDefinitions>

<designguidance:ColorTile
Grid.Column="0"
Background="{ThemeResource SystemFillColorSuccessBackgroundBrush}"
Expand All @@ -82,12 +83,12 @@
ColorValue="#433519, 100%"
ShowSeparator="False" />
<designguidance:ColorTile
Grid.Column="2"
Background="{ThemeResource SystemFillColorCriticalBackgroundBrush}"
ColorBrushName="SystemFillColorCriticalBackgroundBrush"
ColorExplanation="Infobar Background"
ColorName="Accent / Selected Text Background"
ColorName="System / Critical Background"
ColorValue="#442726, 100%"
Grid.Column="2"
ShowSeparator="False" />

</Grid>
Expand All @@ -105,7 +106,7 @@
ColorValue="#60CDFF (100%)"
Foreground="{ThemeResource TextFillColorInverseBrush}"
ShowSeparator="False" />

<designguidance:ColorTile
Grid.Column="1"
Background="{ThemeResource SystemFillColorNeutralBrush}"
Expand Down Expand Up @@ -138,7 +139,7 @@
ColorBrushName="SystemFillColorAttentionBackgroundBrush"
ColorExplanation="Infobar Background"
ColorName="System / Attention Background"
ColorValue="#FFFFFF (0B, 3.26%)"/>
ColorValue="#FFFFFF (0B, 3.26%)" />
<designguidance:ColorTile
Grid.Column="1"
Background="{ThemeResource SystemFillColorNeutralBackgroundBrush}"
Expand Down

0 comments on commit 877f21e

Please sign in to comment.