Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add searchable tags to Icons #1544

Closed
AndrewKeepCoding opened this issue May 21, 2024 · 5 comments · Fixed by #1562
Closed

Add searchable tags to Icons #1544

AndrewKeepCoding opened this issue May 21, 2024 · 5 comments · Fixed by #1562
Labels
app enhancement Requests for general app improvements help wanted Extra attention is needed

Comments

@AndrewKeepCoding
Copy link
Contributor

Issue type

enhancement

Which version of the app?

WinUI 3 Gallery

Description

In the Icons page, you can search by Name and Unitcode point. It'd be easier to find icons if they had tags that represent the symbol or its meaning.

For example, the Color icon, which is a palette, could also be able to be found with [palette] or [theme].

Screenshots

No response

Windows version

No response

Additional context

No response
@AndrewKeepCoding
Copy link
Contributor Author

AndrewKeepCoding commented May 21, 2024 •
edited

If this is a change that could be considered as enhancement, I'd be happy to create a PR for this.

@Jay-o-Way
Copy link
Contributor

Sounds like a fair idea. What would be your solution? Adding a "tag" field in WinUIGallery/DataModel/IconsData.json ?

@AndrewKeepCoding
Copy link
Contributor Author

AndrewKeepCoding commented May 21, 2024 •
edited

Yes. Something like the following. Nothing complicated.

{
  "Code": "E790",
  "Name": "Color",
  "Tags": ["Palette", "Theme"]
},

But since there are too many icons, I'm thinking on implementing the searching logic and some simple tags. The rest can be implemented/improved in the future.

@karkarl karkarl added help wanted Extra attention is needed app enhancement Requests for general app improvements and removed needs-triage labels Jun 13, 2024
@karkarl
Copy link
Collaborator

karkarl commented Jun 13, 2024

That's a great idea! Your contribution is very much welcomed.

@AndrewKeepCoding
Copy link
Contributor Author

I'll create a PR when it's ready.

@AndrewKeepCoding AndrewKeepCoding mentioned this issue Jun 14, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
app enhancement Requests for general app improvements help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Searching icons by tags AndrewKeepCoding/WinUI-Gallery
3 participants
@karkarl @Jay-o-Way @AndrewKeepCoding