Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching icons by tags #1562

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

AndrewKeepCoding
Copy link
Contributor

@AndrewKeepCoding AndrewKeepCoding commented Jun 14, 2024

Description

Closes #1544.
This PR will enable searching icons based on tags on the Iconography page. Icon tags are assigned on the IconsData.json file.

Motivation and Context

The current icon searching is based only on the icon name or its code. Some icon's names are not very intuitive, or some icons can represent several things. So, to get an icon code and if you don't know the icon name, you need to search it manually by scrolling through more than 1400 icons.

How Has This Been Tested?

Tested on the VS.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@AndrewKeepCoding
Copy link
Contributor Author

I added tags to 400 icons and didn't (couldn't) add tags to all >1400 icons. It takes too much time and patience. 😅
I'm expecting the tagging to be improved little by little.

@niels9001
Copy link
Collaborator

🔥🔥🔥

@karkarl
Copy link
Collaborator

karkarl commented Jul 18, 2024

/azp run

@karkarl karkarl merged commit 935fbbe into microsoft:main Jul 19, 2024
2 checks passed
@ghost1372
Copy link
Contributor

Tnx @AndrewKeepCoding for this great pr.
for adding tags you dont need to write them by yourself, in this case we can use ChatGPT :)
as you can see, chatgtp generated 3 tags for each item.

image

@AndrewKeepCoding AndrewKeepCoding deleted the searching-icons-by-tags branch July 20, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add searchable tags to Icons
4 participants