Color > Hight Contrast: Incorrect Highlighting on Theme Toggle

[Zakariathr22]

Which version of the app?

WinUI 3 Gallery

Steps to Reproduce:

1. Navigate to the "Color > Hight Contrast".
2. Toggle the theme using the theme switch button at the top right corner.
3. Observe the changes in the text highlighting.

Screenshots

Before Toggling the theme

After Toggling the theme

Expected Behavior:

The text should maintain consistent highlighting and text visibility regardless of the theme, with proper contrast between the background and text.

Actual Behavior:

After toggling the theme, the text become poorly highlighted, making it less readable and causing visual inconsistency.

[Jay-o-Way]

Got the same on pages: Iconography, Spacing, ColorPaletteResources, to name a few

[Zakariathr22]

Got the same on pages: Iconography, Spacing, ColorPaletteResources, to name a few

The issue in 'SpacingPage' was resolved in #1639

[marcelwgn]

Thanks for reporting that bug @Zakariathr22 ! In case you want to try and fix this, I think an easy solution would be remove the CodePresenter that is on that page since it does not make a lot sense in the high contrast section.

@Jay-o-Way The pages Spacing and Iconography were fixed by the PR @Zakariathr22 linked. ColorPaletteResources is indeed still an issue. If you find other pages that do not properly support the toggle, feel free to create issues for them!

[Jay-o-Way]

Spacing and Iconography were fixed by the PR

That's interesting, because that PR only changes one file...

[marcelwgn]

I guess the Iconography page was fixed by some other changes then. I think there were some changes to finding the element to change theme at some point but I cant remember the PR.