Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Color > HighContrast theme toggle highlight #1680

Merged

Conversation

Zakariathr22
Copy link
Contributor

Description

The changes in this PR prevent the SampleThemeListener from applying theme changes to all child elements, including some textboxes, which do not need to be affected by the theme toggle. These changes address the issue of inconsistent text highlighting in the "High Contrast" section of the ColorPage by improving theme handling. The main changes are:

  • Removed <SampleThemeListener> from ColorPage.
  • Added <SampleThemeListener> to other "Color Sections" pages as needed for better modularity.

Motivation and Context

Fixes #1671

How Has This Been Tested?

Manually Tested by toggling the theme in all sections of the ColorPage and observing the behavior.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works great. Thanks!!

@Jay-o-Way
Copy link
Contributor

@niels9001 still wondering why this theme listener doesn't seem to play nice when built into the example control. Do you know why? My first guess would be different namespaces, but not sure.
#1675 (comment)

@niels9001
Copy link
Contributor

/azp run

@niels9001 niels9001 merged commit 99adbc1 into microsoft:main Dec 8, 2024
2 checks passed
@Zakariathr22 Zakariathr22 deleted the fix/high-contrast-theme-toggle branch December 13, 2024 09:08
@AdhamCl
Copy link

AdhamCl commented Dec 18, 2024

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Color > Hight Contrast: Incorrect Highlighting on Theme Toggle
4 participants