-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add control namespaces to sample page header #1051
Add control namespaces to sample page header #1051
Conversation
The changes look great to me but I'm unable to load a control page for some reason. The app launches but when I try to click on a control, I get the "combase.pdb not loaded" error message. @chingucoding did you also get that error? |
I am not experiencing these issue @gregwoo-microsoft , that's really strange. If you could get a stack trace, it might be easier for me to see what could cause this. |
@chingucoding This is what I am getting. Let me know if this helps.
|
@gregwoo-microsoft Could you try loading the symbols for Microsoft.UI.Xaml.dll? Maybe that helps tracking it down, looking at the stack trace, it seems that selecting an item is broken but that is not something that should be affected by this PR. |
@gregwoo-microsoft Is this good to go? |
Looks awesome! Thank you Marcel :) |
This PR adds the controls/APIs namespace to the top of the controls page:
![Screenshot of AnimatedIcon page with new subheader displaying the controls namespace](https://user-images.githubusercontent.com/16122379/182459429-1e6bd399-38c8-4522-b67a-ea2c89a768e4.png)
Closes #1023