Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add control namespaces to sample page header #1051

Merged

Conversation

marcelwgn
Copy link
Collaborator

@marcelwgn marcelwgn commented Jul 24, 2022

This PR adds the controls/APIs namespace to the top of the controls page:
Screenshot of AnimatedIcon page with new subheader displaying the controls namespace

Closes #1023

WinUIGallery/ItemPage.xaml.cs Show resolved Hide resolved
WinUIGallery/PageHeader.xaml Show resolved Hide resolved
@gregwoo-microsoft
Copy link
Contributor

The changes look great to me but I'm unable to load a control page for some reason. The app launches but when I try to click on a control, I get the "combase.pdb not loaded" error message. @chingucoding did you also get that error?

@marcelwgn
Copy link
Collaborator Author

I am not experiencing these issue @gregwoo-microsoft , that's really strange. If you could get a stack trace, it might be easier for me to see what could cause this.

@gregwoo-microsoft
Copy link
Contributor

gregwoo-microsoft commented Jul 27, 2022

@chingucoding This is what I am getting. Let me know if this helps.

combase.dll!RoFailFastWithErrorContextInternal2(HRESULT hrError, unsigned long cStowedExceptions, _STOWED_EXCEPTION_INFORMATION_V2 * * aStowedExceptionPointers) Line 1471 C++
Microsoft.ui.xaml.dll!7b870d29() Unknown
Microsoft.ui.xaml.dll![Frames below may be incorrect and/or missing, no symbols loaded for Microsoft.ui.xaml.dll] Unknown
[External Code]
WinUIGallery.DesktopWap.dll!AppUIBasics.NavigationRootPage.EnsureNavigationSelection(string id) Line 214 C#
WinUIGallery.DesktopWap.dll!AppUIBasics.ItemPage.OnNavigatedTo(Microsoft.UI.Xaml.Navigation.NavigationEventArgs e) Line 191 C#
[External Code]
WinUIGallery.DesktopWap.dll!AppUIBasics.NavigationRootPage.Navigate(System.Type pageType, object targetPageArguments, Microsoft.UI.Xaml.Media.Animation.NavigationTransitionInfo navigationTransitionInfo) Line 180 C#
WinUIGallery.DesktopWap.dll!AppUIBasics.ItemsPageBase.OnItemGridViewItemClick(object sender, Microsoft.UI.Xaml.Controls.ItemClickEventArgs e) Line 71 C#
[External Code]

@marcelwgn
Copy link
Collaborator Author

@gregwoo-microsoft Could you try loading the symbols for Microsoft.UI.Xaml.dll? Maybe that helps tracking it down, looking at the stack trace, it seems that selecting an item is broken but that is not something that should be affected by this PR.

@marcelwgn
Copy link
Collaborator Author

@gregwoo-microsoft Is this good to go?

@gregwoo-microsoft
Copy link
Contributor

Looks awesome! Thank you Marcel :)

@gregwoo-microsoft gregwoo-microsoft merged commit c1ed234 into microsoft:main Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add namespace to each sample page
3 participants