Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the proper Window in multi-window scenarios #1088

Merged
merged 1 commit into from
Oct 3, 2022

Conversation

bpulliam
Copy link
Contributor

@bpulliam bpulliam commented Oct 3, 2022

Description

Since the origin of WinUI controls gallery is single window, many items like StartupWindow which tells the window information are static and don't work in multi window scenario. Instead, we should call xamlroot to find window object as well as app titlebar object when app content has finished loading

Also made a change where dropdown color in Titlebar page changes app titlebar uielement's color instead of titlebar container color. So that it would be painting it below the text instead of over the text.

Motivation and Context

Fix the issue where changes to the Window titlebar were applied to the wrong window.

How Has This Been Tested?

Manual testing

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@bpulliam bpulliam merged commit 2919ed2 into microsoft:main Oct 3, 2022
@bpulliam bpulliam deleted the user/bpulliam/titlebar branch October 3, 2022 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants