Enable ScrollViewer Zoom and add tab stop #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
At startup time ZoomModeComboBox_SelectionChanged is called, but ZoomSlider is still Null. So Control1.ZoomMode remains ZoomMode.Disabled. You end up with a UI that says ZoomMode is Enabled when in fact its Disabled.
This change has fixed two issues on ScrollViewer:
Zoom not working
ScrollViewer not getting focus.
Motivation and Context
Zoom in/ out on Scrollbar in XCG is not working.
How Has This Been Tested?
Touch works
Ctrl +/- works
Zoom ctrl works
Ctrl + mouse wheel works
Screenshots (if appropriate):
Types of changes