Update Gallery glyphs to current standard #1106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice. Are these files used for WinUI2 or Winui3 Gallery - or both? |
marcelwgn
approved these changes
Oct 19, 2022
|
@Jay-o-Way These changes are targeting the WinUI 3 Gallery, only PRs targeting the winui2 branch are used by the WinUI 2 Gallery. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes:
Motivation and Context
As mentioned in microsoft/microsoft-ui-xaml#7850, there is a note in the documentation to use Unicode points E700+ when referencing glyphs. This change only changes the specific references in the WinUI Gallery code itself.
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes