Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll viewer zoom to 2.0 on startup and rename control x:Name #1113

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

baileydauterman
Copy link
Contributor

Description

Updated the scroll viewer starting zoom to be 2.0 so when users select the control it is more clear what the scroll viewer does. Also renamed the x:name for the scrollviewer form Control1 to ScrollViewerControl to make the name more meaningful.

Motivation and Context

This is a PR to fix issue #121. I picked this because it was the only issue marked as good first issue and was a relatively easy fix.

How Has This Been Tested?

I believe this issue is isolated to the scroll viewer page. If there are tests that need updated I can do this.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@baileydauterman
Copy link
Contributor Author

@microsoft-github-policy-service agree

@bpulliam bpulliam merged commit e69b598 into microsoft:main Nov 11, 2022
@bpulliam
Copy link
Contributor

Nice first fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants