-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New tile carousel on home page + tiles for community & accessibility #1131
New tile carousel on home page + tiles for community & accessibility #1131
Conversation
improves organization
FYI @niels9001 |
WinUIGallery/NewControlsPage.xaml
Outdated
<controls:HeaderTile Title="Windows Design" Source="/Assets/HomeHeaderTiles/style-1x.png" Link="https://docs.microsoft.com/windows/apps/design/"/> | ||
<controls:HeaderTile Title="WinUI Repo" Source="/Assets/HomeHeaderTiles/githubTile.png" Link="https://github.com/microsoft/microsoft-ui-xaml"/> | ||
<controls:HeaderTile Title="Template Studio" Source="/Assets/HomeHeaderTiles/template_studio.png" Link="https://marketplace.visualstudio.com/items?itemName=TemplateStudio.TemplateStudioForWinUICs"/> | ||
<controls:HeaderTile Title="Community Toolkit" Source="/Assets/HomeHeaderTiles/toolkit.png" Link="https://apps.microsoft.com/store/detail/windows-community-toolkit-sample-app/9NBLGGH4TLCQ"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
EDIT: Actually no, linking directly to the Gallery app (so hopefully it opens directly) makes most sense :)
@niels9001 @chingucoding let me know what you think, I added a new flipview/carousel functionality + a new accessibility tile |
too long otherwise
I think we should recalculate the number of items inside the FlipView based on the width of the app and maybe also use a PipsPager at the bottom? Let me know what you think @gregwoo-microsoft. |
Yeah that is a great idea @chingucoding. I can look to add a PipsPager tomorrow. Do you know how to adjust the FlipView based on the app's width? |
I think the best way would be to listen to the FlipViews SizeChanged event and recalculate how many items to show based on that. |
@gregwoo-microsoft @chingucoding I've created the following: gregwoo-microsoft#2 This uses a scrollviewer and will show the scroll buttons whenever the is more content to scroll to. This is also how Store handles its screenshots section and is maybe easier than moving items around in a FlipView😊? (Would be nice to have some sort of adaptive FlipView that can stretch to show more content vs. flipping if not). |
That would also work but I think having a PipsPager and FlipView for this would look better even if it is more complicated to set up. Maybe we could even let it switch the view every x seconds? What are your thoughts @gregwoo-microsoft @niels9001 ? |
Hmm.. looking at the Store homepage carousel and screenshots gallery on the PDP, they seem to favor a ScrollViewer vs. a FlipView. My worry with a FlipView is that you might end up with e.g. 4 items on the first item and 2 on the second item? Not sure if that'd look great. Also discoverability might not be the greatest as the PipsPager might be missed? I'd say, in the end this might be an interesting opportunity to recreate something like the Store carousel - this would also allow the landingspage to be more engaging by providing big images with additional information :). |
Alright, lets do that then. Not sure about the big pictures in the future but I think we'll figure that out then. |
Adding tile gallery
Love the change @niels9001. Thanks for implementing that. I just merged your PR. |
@gregwoo-microsoft Can we get this in? |
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes