Added the Background property to the ProgressRing page #1163
Conversation
| <local:ControlExample.Xaml> | ||
| <x:String> | ||
| <ProgressRing Width="60" Height="60" Value="$(DeterminateProgressValue)" IsIndeterminate="False"/> | ||
| <ProgressRing Width="60" Height="60" Value="$(DeterminateProgressValue)" IsIndeterminate="False" $(Background)/> |
There was a problem hiding this comment.
I think a line break for this would be good so that we don't have vertical scrolling.
There was a problem hiding this comment.
Fixed! :)
| RevealBackgroundProperty1.IsEnabled = showBackgroundProperty; | ||
| } | ||
|
|
||
| private void Background_SelectionChanged2(object sender, SelectionChangedEventArgs e) |
There was a problem hiding this comment.
Could we refactor this to determine only have one handler that selects the correct progressring based on the sender?
There was a problem hiding this comment.
I'm not sure how we can get that information from the sender. Any idea?
There was a problem hiding this comment.
but I agree, let's figure this out before merging it
There was a problem hiding this comment.
We can either set the tag property on the ComboBox and retrieve that through the sender property or doing something like this:
private void Background_SelectionChanged2(object sender, SelectionChangedEventArgs e)
var progressRing = sender == BackgroundComboBox1 ? ProgressRing1 : ProgressRing2;
// Color progress ring accordingly
}There was a problem hiding this comment.
That's perfect! Thank you @chingucoding. I just pushed the change.
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes