Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ProjectReunion version variables with WindowsAppSdk ones #1172

Merged
merged 2 commits into from
Jan 23, 2023

Conversation

bpulliam
Copy link
Contributor

Description

This change retires the ProjectReunionPackageVersion and ProjectReunionWinUIPackageVersion variables that date back to the early days of the project. The variable WindowsAppSdkPackageVersion is more correct and intuitive.

Motivation and Context

One less special case to remember

Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also rename the package/project references for those variables? Or at least remove them?

@marcelwgn marcelwgn merged commit 7ed9c35 into main Jan 23, 2023
@karkarl karkarl deleted the user/bpulliam/unreunion branch February 12, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants