Fix double navigation when selecting search result item. #1185
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix double navigation
Description
When a result item is selected, a method called
EnsureItemIsVisibleInNavigation
updates the selected item on the menu.This triggers the
OnNavigationViewSelectionChanged
method, that navigates to the corresponding view.But right after that, the navigation is called, causing it to navigate again.
WinUI-Gallery/WinUIGallery/Navigation/NavigationRootPage.xaml.cs
Lines 453 to 454 in 2bf63f0
Motivation and Context
This may be related to the issue #972
How Has This Been Tested?
After the change, the app navigates only once to the view.
Types of changes