Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix double navigation when selecting search result item. #1185

Merged
merged 4 commits into from
Feb 7, 2023

Conversation

matheus-inacio
Copy link
Contributor

@matheus-inacio matheus-inacio commented Feb 6, 2023

Fix double navigation

Description

When a result item is selected, a method called EnsureItemIsVisibleInNavigation updates the selected item on the menu.

This triggers the OnNavigationViewSelectionChanged method, that navigates to the corresponding view.

But right after that, the navigation is called, causing it to navigate again.

EnsureItemIsVisibleInNavigation(infoDataItem.Title);
Navigate(typeof(ItemPage), itemId);

Motivation and Context

This may be related to the issue #972

How Has This Been Tested?

After the change, the app navigates only once to the view.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@matheus-inacio
Copy link
Contributor Author

@matheus-inacio please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"

Contributor License Agreement

@microsoft-github-policy-service agree

Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for improving the behavior in that area @matheus-inacio!

@marcelwgn marcelwgn merged commit ae2d7c3 into microsoft:main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants