New Settings UX #1194
Merged
New Settings UX #1194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcelwgn
reviewed
Feb 14, 2023
There was a problem hiding this comment.
I think you want to merge main into this again since this PR doesn't currently compile. Also not sure if having a dependency for settingscard and settingsexpander is worth it. What are your thoughts @gregwoo-microsoft and @bpulliam ?
niels9001
force-pushed
the
niels9001/settingsUX
branch
from
9d70329
to
7d83e1e
Compare
gregwoo-microsoft
approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Thanks for implementing this PR @niels9001! This brings some much-needed consistency when compared to our other inbox apps + what is mentioned in the Windows Design guidelines.
niels9001
force-pushed
the
niels9001/settingsUX
branch
from
6476809
to
5c08dbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new UX for the Settings page that is inline with Windows 11, inbox applications and the Windows Design Guidelines.
It uses the Windows Community Toolkit SettingsCard and SettingsExpander.. more information here: CommunityToolkit/Labs-Windows#129
Description