Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix incorrect links #1233

Merged
merged 1 commit into from
Apr 5, 2023
Merged

fix incorrect links #1233

merged 1 commit into from
Apr 5, 2023

Conversation

insomniachi
Copy link
Contributor

Description

add Folder property ControlInfoDataGroup
if present it will be appended to base URL when navigating to source code for all child items.

Motivation and Context

fixes #1232

How Has This Been Tested?

Manual

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@insomniachi
Copy link
Contributor Author

@microsoft-github-policy-service agree

@niels9001
Copy link
Collaborator

@insomniachi Should we update the .json file as well? Clicking on Colors => Source => XAML still goes to an incorrect URL?

@insomniachi
Copy link
Contributor Author

@niels9001 .json is updated, folder name is added for the group Design guidance.
everything under the group (Typography,Colors,Icons,Accessibility) points to the right url

Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you for fixing this!

@marcelwgn
Copy link
Collaborator

@niels9001 If I click on the xaml link for the colors page, it seems to resolve correctly. Is it still broken for you?

@karkarl
Copy link
Collaborator

karkarl commented Apr 5, 2023

@niels9001 If I click on the xaml link for the colors page, it seems to resolve correctly. Is it still broken for you?

Manually verified. Thanks for the fix @insomniachi :)

@karkarl karkarl merged commit 80dec03 into microsoft:main Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Link to source code is broken for all items under Design guidance section.
4 participants