Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecated icons #1238

Merged
merged 1 commit into from
Mar 30, 2023
Merged

fix deprecated icons #1238

merged 1 commit into from
Mar 30, 2023

Conversation

Jay-o-Way
Copy link
Contributor

Description

Message

Motivation and Context

For western languages this is invisible, but in CJK context, these icons break and show "garbled" chinese caracters.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@marcelwgn marcelwgn requested a review from niels9001 March 30, 2023 17:38
niels9001
niels9001 approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @Jay-o-Way!

@niels9001 niels9001 merged commit 230ad66 into microsoft:main Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelwgn marcelwgn marcelwgn approved these changes

@niels9001 niels9001 niels9001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Jay-o-Way @niels9001 @marcelwgn