-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tweak fontsizes #1240
tweak fontsizes #1240
Conversation
Best not to use font-size 14 on icons, they're designed with 16px in mind. Quote from your own app: "The minimum values should be 12px Regular, 14px Semibold"
Hey Jay-o-Way! Thanks for your contribution. Do you mind adding more detailed before and after changes photos in your PR description? |
@karenbtlai done. Visually, it's absolutely minute. More a matter of principle and design/code habits. |
Synced with the design team, and by default we should adhere to using 16/24/32/48 as @Jay-o-Way pointed out. However, FontIcon/SymbolIcon uses 20 by default (I always was under the impression it would default to 16, like normal text..). So we still have to manually set these to "16". Chart for comparison (as @Jay-o-Way pointed out, 14 causes blurriness on higher resolutions screens): This is also inline with icons in e.g. the Start Menu or systemtray: Also visually checks out in Figma: @Jay-o-Way Great catch, we probably need to update the icon sizes for the PowerToys flyout as well to 16 instead of 14. |
Could that be, because of a style somewhere, perhaps? |
Yeah, I'm guessing this might be from the pre-WinUI era where in general icons and fonts were bigger. |
@niels9001 Feel free to merge this if it's fine now (I think you have much more knowledge on this matter than me) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Description
Just small changes
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes