-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MDL2 from code #1260
Remove MDL2 from code #1260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can't just remove it like that. We use SymbolThemeFontFamily that redirects to appropriate font for controls that use icons. Otherwise it will fall back to Xaml Auto Font Family which is a text font. Also, all these instances would need to be tested, for example, AnimatedIcon
@tashatitova that's highly peculiar because this very app shows examples just like this. <Fonticon glyph=""> Also (as mentioned in the issue) it renders just fine. Can you show how it looks? Need some convincing here. |
FontIcon defaults to SymbolThemeFontFamily, but usage without setting the FontFamily isn't something recommended, at least as far as I've seen. Textblocks do come without font sent on them, FontIcons usually specify it. |
Can you show how it looks on your device? |
This speaks for itself. It's 100% redundant.
Have a look at WinUI 3 Gallery, it's a good source: <DropDownButton AutomationProperties.Name="Email">
<DropDownButton.Content>
<FontIcon Glyph=""/>
</DropDownButton.Content>
<DropDownButton.Flyout>
<MenuFlyout Placement="Bottom">
<MenuFlyoutItem Text="Send">
<MenuFlyoutItem.Icon>
<FontIcon Glyph=""/>
</MenuFlyoutItem.Icon>
</MenuFlyoutItem>
<MenuFlyoutItem Text="Reply">
<MenuFlyoutItem.Icon>
<FontIcon Glyph=""/>
</MenuFlyoutItem.Icon> |
@niels9001 I'm ready |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, changes look good.
FontIcon falls back automatically to SymbolThemeFontFamily
Description
Let's not use MDL2 :)
Motivation and Context
Closes: #1252
Types of changes