Using JsonSerializer instead of JsonObject #1276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for deserializing async/await ControlInfoData.json
Since we use JsonSerializer, we don't need to define a default value
marcelwgn
requested changes
Apr 21, 2023
marcelwgn
approved these changes
Apr 23, 2023
marcelwgn
approved these changes
Apr 24, 2023
karkarl
requested changes
Apr 28, 2023
done |
karkarl
approved these changes
May 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using System.Text.Json.JsonSerializer instead of JsonObject for deserializing ControlInfoData.json file.
By using JsonSerializer, the codes become simpler and less, and we can use Async/Await
#1270
Description
Motivation and Context
How Has This Been Tested?
Tested On my Laptop
Screenshots (if appropriate):
Types of changes