Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display Windows App SDK and Runtime version info #1282

Merged
merged 2 commits into from
May 9, 2023
Merged

Display Windows App SDK and Runtime version info #1282

merged 2 commits into from
May 9, 2023

Conversation

Scottj1s
Copy link
Member

@Scottj1s Scottj1s commented May 8, 2023 •
edited

Uses auto-init bootstrapper version info contained in WindowsAppSDK-VersionInfo.cs to generate version strings for Home and Settings pages. This also demonstrates how app developers can use version info for other purposes.

@Scottj1s Scottj1s requested a review from bpulliam May 8, 2023 21:52
bpulliam
bpulliam approved these changes May 9, 2023
View reviewed changes
Copy link
Contributor

@bpulliam bpulliam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're here, we can remove line 155 from Settingspage.xaml: . We don't use XamlBehaviors anywhere.

@Scottj1s Scottj1s merged commit c140270 into main May 9, 2023
@Scottj1s Scottj1s deleted the user/sjones/wasdk_versions branch May 9, 2023 20:08
@bpulliam bpulliam mentioned this pull request May 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpulliam bpulliam bpulliam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Scottj1s @bpulliam