Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UX] Adding Mica #1287

Merged
merged 3 commits into from
May 15, 2023
Merged

[UX] Adding Mica #1287

merged 3 commits into from
May 15, 2023

Conversation

niels9001
Copy link
Collaborator

@niels9001 niels9001 commented May 14, 2023 •
edited

Description

The WinUI Gallery now has Mica as it's background, addressing: #1066

  • Added Mica to the MainWindow
  • Removing unused code from SettingsPage.xaml.cs

Before vs. after
image

Theme switching

Recording.2023-05-14.203129.mp4

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

karkarl
karkarl approved these changes May 15, 2023
View reviewed changes
Copy link
Collaborator

@karkarl karkarl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@karkarl karkarl merged commit 6a0b60d into main May 15, 2023
@niels9001 niels9001 deleted the niels9001/mica branch October 26, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karkarl karkarl karkarl approved these changes

@marcelwgn marcelwgn Awaiting requested review from marcelwgn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@niels9001 @karkarl