Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mica Sample Update #1290

Merged
merged 4 commits into from
May 26, 2023
Merged

Mica Sample Update #1290

merged 4 commits into from
May 26, 2023

Conversation

karkarl
Copy link
Collaborator

@karkarl karkarl commented May 15, 2023

Description

Updating the Mica sample now that it is available in WASDK 1.3, and way easier to implement!

Note: This is a port from internal repo PR - 8915253

Motivation and Context

Fixes #1286

Screenshots (if appropriate):

image

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@karkarl karkarl requested a review from niels9001 May 15, 2023 23:08
@@ -19,14 +19,19 @@
mc:Ignorable="d">

<StackPanel>
<local:ControlExample HeaderText="Create a window with a built-in Mica system backdrop."
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@karkarl I'd include a XAML snippet here as well now that's fully supported? It's probably how most devs would (like) to use it?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should be in the Xaml snippet? I can't think of anything relevant to mica implementation to put in there.

Copy link
Collaborator

@niels9001 niels9001 May 16, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<Window.SystemBackdrop>
     <MicaBackdrop/>
</Window.SystemBackdrop>

and

<Window.SystemBackdrop>
    <DesktopAcrylicBackdrop/>
</Window.SystemBackdrop>

That's the easiest way to add Mica or Acrylic to a Window without any code behind.. there was a bug blocking this but was fixed with 1.3.1 - it now works great :-).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added!

Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! See minor comment - having a XAML snippet would be a nice addition!

I pushed a commit prettyfing the sample pages a bit :)

@karkarl karkarl merged commit 0a300bf into main May 26, 2023
@mdtauk
Copy link

mdtauk commented Jul 9, 2023

Did you also include the sample with one for Mica Alt?

<Window.SystemBackdrop>
    <MicaBackdrop Kind="BaseAlt"/>
</Window.SystemBackdrop>

And you can also use this to achieve the regular Mica

<Window.SystemBackdrop>
    <MicaBackdrop Kind="Base"/>
</Window.SystemBackdrop>

@niels9001 niels9001 deleted the user/karkarl/UpdateMicaSample branch October 26, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Mica XAML and C# samples
3 participants