Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UX] Minor UI tweaks #1305

Merged
merged 11 commits into from
Nov 1, 2023
Merged

[UX] Minor UI tweaks #1305

merged 11 commits into from
Nov 1, 2023

Conversation

niels9001
Copy link
Collaborator

Description

Typography:

  • Make the copy button always visible
  • Optimized fontsizes for better readability

Colors:

  • Small fixes to color labels/brush names
  • Replace the default copy button with the CopyButton.

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@Jay-o-Way Jay-o-Way left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two things

Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only second what @Jay-o-Way said, otherwise this looks fine.

@niels9001
Copy link
Collaborator Author

@chingucoding @Jay-o-Way Thanks! Addressed your feedback!

@karkarl
Copy link
Collaborator

karkarl commented Aug 28, 2023

Please rebase from main to get the latest CI build fixes and run an Accessibility Insights pass on the updated xaml pages. (Automated test pass coming soon!)

@karkarl
Copy link
Collaborator

karkarl commented Oct 30, 2023

@niels9001 Can you rebase from main to get the test failure fix?

@niels9001
Copy link
Collaborator Author

@niels9001 Can you rebase from main to get the test failure fix?

Done! CI should hopefully pass now :)

@karkarl karkarl merged commit 74d8d92 into main Nov 1, 2023
2 checks passed
@karkarl karkarl deleted the niels9001/color-improvements branch February 12, 2024 23:50
karkarl pushed a commit that referenced this pull request Jul 15, 2024
## Description
Typography:
- Make the copy button always visible
- Optimized fontsizes for better readability

Colors:
- Small fixes to color labels/brush names
- Replace the default copy button with the `CopyButton`.

---------

Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants