Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with treeview icon on high contrast #1308

Merged

Conversation

marcelwgn
Copy link
Collaborator

Description

Fixes issues with one icon not being visible on the TreeView page on high contrast.

Motivation and Context

Fixes #648

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@marcelwgn marcelwgn force-pushed the dev/648-fix-treeview-high-contrast-issue branch from 06b7755 to 9b93f4d Compare August 28, 2023 16:19
@karkarl
Copy link
Collaborator

karkarl commented Oct 16, 2023

Can you add a before and after photo of the fix?

@karkarl karkarl merged commit e4952a9 into microsoft:main Nov 1, 2023
2 checks passed
karkarl pushed a commit that referenced this pull request Jul 15, 2024
<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->
Fixes issues with one icon not being visible on the TreeView page on
high contrast.

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Fixes #648

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

---------

Co-authored-by: Niels Laute <niels.laute@live.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TreeView sample does not comply with contrast ratios for icons in file style view.
3 participants