Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding pages for new AnnotatedScrollBar, ScrollView and ItemsView controls #1351

Merged
merged 5 commits into from
Sep 6, 2023
Merged

Adding pages for new AnnotatedScrollBar, ScrollView and ItemsView controls #1351

merged 5 commits into from
Sep 6, 2023

Conversation

RBrid
Copy link
Contributor

@RBrid RBrid commented Sep 6, 2023

Description

  • Deleting unused ScrollViewer2Page files.
  • Fixing bugs in existing ParallaxView, ListView and ScrollViewer pages.
  • Adding new ParallaxView scenario working with the new ScrollView.
  • Adding new control pages for ScrollView, ItemsView and AnnotatedScrollBar.
    (Controls' color and black&white icons are temporary placeholders.)

Motivation and Context

Adding samples for the newly released WinAppSDK 1.4 controls.

How Has This Been Tested?

Ad-hoc testing and testing with Accessibility Insights for Windows tool.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@RBrid RBrid added the enhancement Expand an existing sample or add feature to app label Sep 6, 2023
@RBrid RBrid requested a review from karkarl September 6, 2023 01:23
@RBrid RBrid self-assigned this Sep 6, 2023
karkarl
karkarl reviewed Sep 6, 2023
View reviewed changes
WinUIGallery/Assets/ControlImages/AnnotatedScrollBar.png Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pinged the design team requesting new icons. Waiting to hear back from them.

@RBrid RBrid requested a review from karkarl September 6, 2023 21:07
@RBrid RBrid merged commit 4544d45 into main Sep 6, 2023
2 checks passed
@karkarl karkarl deleted the user/rbrid/NewControlPages2 branch February 12, 2024 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karkarl karkarl karkarl approved these changes

Assignees

@RBrid RBrid

Labels
enhancement Expand an existing sample or add feature to app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@RBrid @karkarl