Remove WindowHelper from FilePicker sample code #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@microsoft-github-policy-service agree |
karkarl
approved these changes
Jan 16, 2024
AndrewKeepCoding
deleted the
filepicker-sample-code-without-windowhelper
branch
|
@AndrewKeepCoding shouldn't the code snippets say App.MainWindow instead 👀? |
AndrewKeepCoding
restored the
filepicker-sample-code-without-windowhelper
branch
|
@MartinZikmund Thanks for pointing that out. 😵 |
3 tasks
karkarl
pushed a commit
that referenced
this pull request
Jan 17, 2024
## Description Corrects the `FilePicker` sample code modified by #1396.
karkarl
pushed a commit
that referenced
this pull request
Jul 15, 2024
## Description Removed the WinUI3Helper class from the `FilePicker` sample code and showed how to get the `MainWindow` from the `App` class instead. ## Motivation and Context The sample code for the `FilePicker` controls uses the WindowHelper class which is implemented as a helper class in this project. This is very confusing because it looks like the WindowHelper class belongs to WinUI 3 and when one tries to use that code in their apps it just doesn't work. I find several questions in StackOverflow related to this and I think it's better not to use the WindowHelper in sample code.
karkarl
pushed a commit
that referenced
this pull request
Jul 15, 2024
## Description Corrects the `FilePicker` sample code modified by #1396.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed the WinUI3Helper class from the
FilePickersample code and showed how to get theMainWindowfrom theAppclass instead.Motivation and Context
The sample code for the
FilePickercontrols uses the WindowHelper class which is implemented as a helper class in this project. This is very confusing because it looks like the WindowHelper class belongs to WinUI 3 and when one tries to use that code in their apps it just doesn't work. I find several questions in StackOverflow related to this and I think it's better not to use the WindowHelper in sample code.How Has This Been Tested?
Run the app and confirmed its content.
Screenshots (if appropriate):
Types of changes