Change DropDownButton's MenuFlyout Placement to be left-aligned #1400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RBrid
approved these changes
Nov 9, 2023
karkarl
pushed a commit
that referenced
this pull request
Jul 15, 2024
## Description Once [PR 9838266: Fix text truncation on DropDownButton MenuFlyout](https://microsoft.visualstudio.com/WinUI/_git/microsoft-ui-xaml-lift/pullrequest/9838266) is completed, DropDownButton's MenuFlyout will no longer truncate longer text when text is scaled up. As a result, at the WinUI3 Gallery app-level, we need to set MenuFlyout's Placement to BottomEdgeAlignedLeft, so that longer text will not end result in MenuFlyout covering the NavigationView. ## Motivation and Context This helps resolve an accessibility issue, in tandem with controls-side changes in the above mentioned PR. ## How Has This Been Tested? Ad-hoc testing ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) --------- Co-authored-by: Christine Yan <christineyan@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Once PR 9838266: Fix text truncation on DropDownButton MenuFlyout is completed, DropDownButton's MenuFlyout will no longer truncate longer text when text is scaled up. As a result, at the WinUI3 Gallery app-level, we need to set MenuFlyout's Placement to BottomEdgeAlignedLeft, so that longer text will not end result in MenuFlyout covering the NavigationView.
Motivation and Context
This helps resolve an accessibility issue, in tandem with controls-side changes in the above mentioned PR.
How Has This Been Tested?
Ad-hoc testing
Types of changes