Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cleanup] Remove unused controlicons #1405

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Conversation

niels9001
Copy link
Collaborator

This PR removes a bunch of unused control icon assets and the links in the ControlDataInfo.json. It also renames ImageIconPath to IconGlyph as we are using those for the navview and are actual icons vs. image :).

Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for cleaning that up. Is it correct that some controls/sections still don't have an icon (e.g. the text section)?

@niels9001 niels9001 merged commit cab6cf5 into main Nov 22, 2023
2 checks passed
@niels9001 niels9001 deleted the niels9001/cleanup-controlicons branch November 22, 2023 13:31
karkarl pushed a commit that referenced this pull request Jul 15, 2024
This PR removes a bunch of unused control icon assets and the links in
the `ControlDataInfo.json`. It also renames `ImageIconPath` to
`IconGlyph` as we are using those for the navview and are actual icons
vs. image :).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants