Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing ListBox XAML code example syntax #1408

Merged
merged 1 commit into from
Nov 26, 2023
Merged

Fixing ListBox XAML code example syntax #1408

merged 1 commit into from
Nov 26, 2023

Conversation

DimitarNestorov
Copy link
Contributor

Description

The ListBox example is missing / in the closing tags of the options

Motivation and Context

Examples shouldn't have invalid syntax

How Has This Been Tested?

N/A

Screenshots (if appropriate):

Screenshot 2023-11-23 102932

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@marcelwgn marcelwgn merged commit 33418db into microsoft:main Nov 26, 2023
2 checks passed
@marcelwgn
Copy link
Collaborator

Thank you for fixing this @DimitarNestorov!

@DimitarNestorov DimitarNestorov deleted the patch-1 branch November 26, 2023 15:00
karkarl pushed a commit that referenced this pull request Jul 15, 2024
<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->
The ListBox example is missing `/` in the closing tags of the options

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
Examples shouldn't have invalid syntax

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->
N/A

## Screenshots (if appropriate):
![Screenshot 2023-11-23
102932](https://github.com/microsoft/WinUI-Gallery/assets/8790386/8bc8d159-7369-4d97-a2de-7b496ada9e21)

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants