-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incremental Fixes to Refactor Codebase #1449
Incremental Fixes to Refactor Codebase #1449
Conversation
<x:String x:Key="ControlsName">All samples</x:String> | ||
<x:String x:Key="AppTitleName">WinUI 3 Gallery</x:String> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With regard to how localized apps would do this, we would not define this in XAML but rather add the resource to the Resources.resw file instead. To be fair, we don't do it elsewhere but wanted to mention it given folks use this app for guidance and to learn about WinUI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Albeit you just moved it so maybe this is something for another time
/azp run |
## Description First attempt to clean up the codebase: - Clean up themeresources and styles in App.xaml - Fix minimal mode TitleBar layout - CaptureElement and AnnotatedScrollBar Icons ## Motivation and Context Part of #1279 efforts
Description
First attempt to clean up the codebase:
Motivation and Context
Part of #1279 efforts