Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to WinAppSDK 1.5 and .NET8; PublishSingleFile for unpackaged configs; fix compile warnings #1483

Merged
merged 10 commits into from
Mar 12, 2024
Merged

Update to WinAppSDK 1.5 and .NET8; PublishSingleFile for unpackaged configs; fix compile warnings #1483

merged 10 commits into from
Mar 12, 2024

Conversation

Scottj1s
Copy link
Member

@Scottj1s Scottj1s commented Mar 7, 2024

No description provided.

@Scottj1s Scottj1s changed the title Update to WinAppSDK 1.5, .NET8, and PublishSingleFile (for unpackaged configs) Update to WinAppSDK 1.5 and .NET8; PublishSingleFile for unpackaged configs; fix compile warnings Mar 8, 2024
@Scottj1s
Copy link
Member Author

/azp run

@Scottj1s
Copy link
Member Author

/azp run

@Scottj1s
Copy link
Member Author

/azp run

@Scottj1s
Copy link
Member Author

/azp run

@Scottj1s Scottj1s merged commit 2f7da4d into main Mar 12, 2024
1 check passed
@Jay-o-Way
Copy link
Contributor

Jay-o-Way commented Mar 24, 2024 •
edited

@Scottj1s something tells me the following should be updated too. Am I right?

WinUI-Gallery/WinUIGallery/ItemPage.xaml.cs

Line 36 in d664b72

private static string WinUIBaseUrl = "https://github.com/microsoft/microsoft-ui-xaml/tree/winui3/release/1.4-stable/controls/dev/";

WinUI-Gallery/WinUIGallery/DataModel/ControlInfoData.json

Line 57 in d664b72

"Uri": "https://github.com/microsoft/microsoft-ui-xaml/blob/winui3/release/1.4-stable/controls/dev/CommonStyles/Common_themeresources_any.xaml"

Also note that the trailing slash of ...controls/dev/ plus the leading slash in the "SourcePath": e.g. /CommonStyles/TextBlock_themeresources.xaml gives a double slash in the resulting URI.
image

@Scottj1s
Copy link
Member Author

Scottj1s commented Apr 3, 2024

@Scottj1s something tells me the following should be updated too. Am I right?

Thanks Jay!
https://github.com/microsoft/WinUI-Gallery/pull/1523/files

@Scottj1s Scottj1s deleted the user/sjones/wasdk15_net8_publishsinglefile branch April 3, 2024 17:46
karkarl pushed a commit that referenced this pull request Jul 15, 2024
@Scottj1s @karkarl
Update to WinAppSDK 1.5 and .NET8; PublishSingleFile for unpackaged c…
ebc2f4c 
…onfigs; fix compile warnings (#1483)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpulliam bpulliam bpulliam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Scottj1s @Jay-o-Way @bpulliam