Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust code padding #1490

Merged
merged 1 commit into from
Mar 29, 2024
Merged

adjust code padding #1490

merged 1 commit into from
Mar 29, 2024

Conversation

Jay-o-Way
Copy link
Contributor

@Jay-o-Way Jay-o-Way commented Mar 10, 2024

Description

Remove padding of UserControl and Grid, and set (bottom)margin on ContentPresenter.

Motivation and Context

fixes #1489, 1501

How Has This Been Tested?

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

P.S. It's Styler that moved the VisualStateManager bits around

@karkarl
Copy link
Collaborator

karkarl commented Mar 28, 2024

/azp run

@marcelwgn
Copy link
Collaborator

Thank you for fixing this @Jay-o-Way , however please next time don't check in code formatting changes on that scale since it makes reviewing very difficult.

@marcelwgn marcelwgn merged commit 49f21df into microsoft:main Mar 29, 2024
2 checks passed
@Jay-o-Way Jay-o-Way deleted the code-scrollviewer branch March 29, 2024 16:45
karkarl pushed a commit that referenced this pull request Jul 15, 2024
…ugh scrollbars (#1490)

<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->
Remove padding of UserControl and Grid, and set (bottom)margin on
ContentPresenter.

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
fixes #1489, ~1501~

## How Has This Been Tested?
<!--- Please describe in detail how you tested your changes. -->
<!--- Include details of your testing environment, and the tests you ran
to -->
<!--- see how your change affects other areas of the code, etc. -->

## Screenshots (if appropriate):

![image](https://github.com/microsoft/WinUI-Gallery/assets/65828559/d6aa1fed-1117-415d-8bb1-d8c7bd55bd46)

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)

P.S. It's **Styler** that moved the **VisualStateManager** bits around
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Scrollbar overlaps code
4 participants