[Colors] Replace ComboBox with SelectorBar #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Link #1462 |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
marcelwgn
reviewed
Mar 19, 2024
WinUIGallery/Controls/DesignGuidance/ColorSections/HighContrastSection.xaml
Show resolved
Hide resolved
| @@ -13,7 +13,10 @@ | |||
| <!-- Colors section --> | |||
| <StackPanel Spacing="{StaticResource ColorSectionSpacing}"> | |||
| <!-- Text --> | |||
| <designguidance:ColorPageExample Title="Text" Description="For UI labels and static text"> | |||
| <designguidance:ColorPageExample | |||
There was a problem hiding this comment.
Just making sure the spacing of these pages with the selectorbar is pretty much consistent for all of those pages. Same with the color updates.
marcelwgn
approved these changes
Mar 19, 2024
|
/azp run |
2 similar comments
|
/azp run |
|
/azp run |
karkarl
pushed a commit
that referenced
this pull request
Jul 15, 2024
Replacing the ComboBox with the SelectorBar so it's easier to see all the different categories of colors and immediately jump to those. 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing the ComboBox with the SelectorBar so it's easier to see all the different categories of colors and immediately jump to those.