-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Design guidance] Additional pages #1531
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Few small comments.
/azp run |
2 similar comments
/azp run |
/azp run |
/azp run |
Aah, great catch! Updated the image! |
/azp run |
1 similar comment
/azp run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
few suggestions, as also commented in #1531 feel free to adapt where needed
/azp run |
…UI-Gallery into niels9001/geometry
@Jay-o-Way Made some tweaks based on your feedback, I think for the spacing on the lists for spacing / typeramp we are good as its per what the design folks created for us |
/azp run |
## Description - Updated the design guidance menu names to be inline with the docs (e.g. Icons => Iconography, Colors => Color) and sorted alphabetically. - Moved the Card stroke brush on the Stroke colors page to the top, so it's inline with the Card background brush and the control strokes are grouped. - Adding a bit more spacing between the color sections - Left aligned type ramp image on the Typography page - Added a new Geometry page explaining how to use the CornerRadius resources: ![image](https://github.com/microsoft/WinUI-Gallery/assets/9866362/962ffeff-3b70-4c92-bba8-131a43136664) - Added a new Spacing page showing a spacing ramp and some common UI examples with redlines: ![image](https://github.com/microsoft/WinUI-Gallery/assets/9866362/4f5656d2-f867-4905-a9b7-1e34010b213c) ## Motivation and Context <!--- Why is this change required? What problem does it solve? --> <!--- If it fixes an open issue, please link to the issue here. --> ## How Has This Been Tested? <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) --------- Co-authored-by: Karen Lai <biilai@microsoft.com> Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
Description
Updated the design guidance menu names to be inline with the docs (e.g. Icons => Iconography, Colors => Color) and sorted alphabetically.
Moved the Card stroke brush on the Stroke colors page to the top, so it's inline with the Card background brush and the control strokes are grouped.
Adding a bit more spacing between the color sections
Left aligned type ramp image on the Typography page
Added a new Geometry page explaining how to use the CornerRadius resources:
![image](https://private-user-images.githubusercontent.com/9866362/328033914-962ffeff-3b70-4c92-bba8-131a43136664.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3Mjk4OTMsIm5iZiI6MTcyNDcyOTU5MywicGF0aCI6Ii85ODY2MzYyLzMyODAzMzkxNC05NjJmZmVmZi0zYjcwLTRjOTItYmJhOC0xMzFhNDMxMzY2NjQucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjdUMDMzMzEzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MjY0MWZmMzExNWRlMmVhMjA1YTE4NmU0MTFhODA2NGEwODUxZGQ0NDQ3YjQ1MzJjMjBiNDI1Nzk2MTYwMjU0MSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.MAhZ84JszPyHUNVWM4-4jad6RXbDAlAOImzjaSeaOh8)
Added a new Spacing page showing a spacing ramp and some common UI examples with redlines:
![image](https://private-user-images.githubusercontent.com/9866362/328033862-4f5656d2-f867-4905-a9b7-1e34010b213c.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3Mjk4OTMsIm5iZiI6MTcyNDcyOTU5MywicGF0aCI6Ii85ODY2MzYyLzMyODAzMzg2Mi00ZjU2NTZkMi1mODY3LTQ5MDUtYTliNy0xZTM0MDEwYjIxM2MucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyNyUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjdUMDMzMzEzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWE3MTU5YzFlMWRlZWY5OWZiNDRhYzFkOThlYjczMTBlMDAzMDAwODI4MGZmODdiOTg5YTg2OWQwMjZiMDExMyZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.B6YGJFv5OsXRUpUAYdTA2r9gZlvYWLq0vTEspDgEVx8)
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes