-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Selectorbar for Sample Code #1540
Conversation
Does this solve #704? |
No. we need to disable horizontal scroll |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for creating this PR!
I think porting the SwitchPresenter control over just for this is a bit overkill, this problem can also be solved with a bit of code-behind. Also, given that people also use this app's source code for reference, introducing a new control just for this doesn't seem like the best idea.
I saw that the gallery uses some communitytoolkit Nuget packages. |
We are in fact using Community Toolkit packages, that is correct. I would argue though, in this case, porting a complete control for something one could do with a few lines of code behind is overkill. |
ok, what do you suggest? Changing visibility? Frame? |
I would probably use a ContentPresenter and have that switch the content |
@marcelwgn I saw your last message late, I sent 2 commits, First by changing the visibility and lastly the suggestion you gave. |
This comment was marked as resolved.
This comment was marked as resolved.
This reverts commit ed78d49.
@Jay-o-Way i reverted last commit (ContentPresenter) now everything is working fine |
Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks!!
/azp run |
<!--- Provide a general summary of your changes in the Title above --> related to #1535 Full Code (Xaml/C#) ![00002](https://github.com/microsoft/WinUI-Gallery/assets/9213496/e3e8d37f-089f-4220-96ee-b3e48c79fa26) Single Code (Xaml Only) ![00001](https://github.com/microsoft/WinUI-Gallery/assets/9213496/b411528b-b79e-4f1f-9ba8-f42edab66fa9) ## Description ## Motivation and Context ## How Has This Been Tested? Tested on my Laptop ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) --------- Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
<!--- Provide a general summary of your changes in the Title above --> related to #1535 Full Code (Xaml/C#) ![00002](https://github.com/microsoft/WinUI-Gallery/assets/9213496/e3e8d37f-089f-4220-96ee-b3e48c79fa26) Single Code (Xaml Only) ![00001](https://github.com/microsoft/WinUI-Gallery/assets/9213496/b411528b-b79e-4f1f-9ba8-f42edab66fa9) ## Description ## Motivation and Context ## How Has This Been Tested? Tested on my Laptop ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change) --------- Co-authored-by: Jay <65828559+Jay-o-Way@users.noreply.github.com>
related to #1535
Full Code (Xaml/C#)
Single Code (Xaml Only)
Description
Motivation and Context
How Has This Been Tested?
Tested on my Laptop
Screenshots (if appropriate):
Types of changes