-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Details on new pages #1545
Merged
Merged
Details on new pages #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niels9001
requested changes
Jun 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! :) |
niels9001
approved these changes
Jun 13, 2024
If it works on W10/MDL2, please go ahead! |
/azp run |
Hard to say. This app is, as most of Windows, clearly focussed on the Win 11 Fluent style... 🤷🏻♂️ |
karkarl
pushed a commit
that referenced
this pull request
Jul 15, 2024
## Description Few small things ## Motivation and Context ...that weren't perfect I would also suggest this icon (yay or nay?) ![image](https://github.com/microsoft/WinUI-Gallery/assets/65828559/880ee6bc-bab3-4ba7-9c6b-5642dab23a85) ## Screenshots (if appropriate): (before) ![image](https://github.com/microsoft/WinUI-Gallery/assets/65828559/61dfb1d4-3f72-4d46-92fe-95a8ff62f7ad) ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
karkarl
pushed a commit
that referenced
this pull request
Jul 15, 2024
## Description Few small things ## Motivation and Context ...that weren't perfect I would also suggest this icon (yay or nay?) ![image](https://github.com/microsoft/WinUI-Gallery/assets/65828559/880ee6bc-bab3-4ba7-9c6b-5642dab23a85) ## Screenshots (if appropriate): (before) ![image](https://github.com/microsoft/WinUI-Gallery/assets/65828559/61dfb1d4-3f72-4d46-92fe-95a8ff62f7ad) ## Types of changes - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Few small things
Motivation and Context
...that weren't perfect
I would also suggest this icon (yay or nay?)
![image](https://private-user-images.githubusercontent.com/65828559/329799347-880ee6bc-bab3-4ba7-9c6b-5642dab23a85.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3Mjc3NjcsIm5iZiI6MTcyNDcyNzQ2NywicGF0aCI6Ii82NTgyODU1OS8zMjk3OTkzNDctODgwZWU2YmMtYmFiMy00YmE3LTljNmItNTY0MmRhYjIzYTg1LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI3VDAyNTc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTY4M2Q1NmYwYTcwMGNhMTA5MjY1N2RhZWIxNDFmMjAzNGNmNDNlYjBmYjk0MjI2MjE4NjE2ZmY1MGZlODEzNWQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.myalW2QyzPog-VVPnTFBxtixAMUosFe8WcNEV42gy9g)
Screenshots (if appropriate):
(before)
![image](https://private-user-images.githubusercontent.com/65828559/332403327-61dfb1d4-3f72-4d46-92fe-95a8ff62f7ad.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ3Mjc3NjcsIm5iZiI6MTcyNDcyNzQ2NywicGF0aCI6Ii82NTgyODU1OS8zMzI0MDMzMjctNjFkZmIxZDQtM2Y3Mi00ZDQ2LTkyZmUtOTVhOGZmNjJmN2FkLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA4MjclMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwODI3VDAyNTc0N1omWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTQ4OTUwNGZjYWEyOGE2NTI0ZDE0N2VmYzhlYjMxODVkOWNlNTIzYTJlOTM0NWUyZjQ4OTVkYzg2Yjk0Y2QyZjcmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.n-IKjr778Vtam208Odxx5cqVj2NAYJSMCSv4SOj0sx4)
Types of changes