Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Details on new pages #1545

Merged
merged 2 commits into from
Jun 14, 2024
Merged

Conversation

Jay-o-Way
Copy link
Contributor

Description

Few small things

Motivation and Context

...that weren't perfect

I would also suggest this icon (yay or nay?)
image

Screenshots (if appropriate):

(before)
image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@karkarl karkarl requested a review from niels9001 June 11, 2024 22:49
Copy link
Collaborator

@niels9001 niels9001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

The titles + values no longer align horizontally?

@Jay-o-Way
Copy link
Contributor Author

Fixed! :)
Thoughts on the icon?

@niels9001
Copy link
Collaborator

@niels9001 Thoughts on the icon? (it's not included - yet)

If it works on W10/MDL2, please go ahead!

@Jay-o-Way
Copy link
Contributor Author

If it works on W10/MDL2,

Good point 👍🏻 It's available in MDL2, but it looks a bit different...
image

@karkarl
Copy link
Collaborator

karkarl commented Jun 13, 2024

/azp run

@niels9001
Copy link
Collaborator

If it works on W10/MDL2,

Good point 👍🏻 It's available in MDL2, but it looks a bit different... image

I'd suggest we leave things as in then?

@Jay-o-Way
Copy link
Contributor Author

I'd suggest we leave things as in then?

Hard to say. This app is, as most of Windows, clearly focussed on the Win 11 Fluent style... 🤷🏻‍♂️

@niels9001 niels9001 merged commit 990ef48 into microsoft:main Jun 14, 2024
2 checks passed
karkarl pushed a commit that referenced this pull request Jul 15, 2024
## Description

Few small things

## Motivation and Context

...that weren't perfect

I would also suggest this icon (yay or nay?)

![image](https://github.com/microsoft/WinUI-Gallery/assets/65828559/880ee6bc-bab3-4ba7-9c6b-5642dab23a85)

## Screenshots (if appropriate):

(before)

![image](https://github.com/microsoft/WinUI-Gallery/assets/65828559/61dfb1d4-3f72-4d46-92fe-95a8ff62f7ad)

## Types of changes

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
karkarl pushed a commit that referenced this pull request Jul 15, 2024
## Description

Few small things

## Motivation and Context

...that weren't perfect

I would also suggest this icon (yay or nay?)

![image](https://github.com/microsoft/WinUI-Gallery/assets/65828559/880ee6bc-bab3-4ba7-9c6b-5642dab23a85)

## Screenshots (if appropriate):

(before)

![image](https://github.com/microsoft/WinUI-Gallery/assets/65828559/61dfb1d4-3f72-4d46-92fe-95a8ff62f7ad)

## Types of changes

- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants