-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: No contrast of the CopyButton in the color guidance page #1554
Fix: No contrast of the CopyButton in the color guidance page #1554
Conversation
Here's a weird idea? What would happen if we remove all of this manual work and reset the button to defaults?! 🤓 |
...On-topic... WinUI-Gallery/WinUIGallery/Controls/DesignGuidance/ColorSections/TextSection.xaml Lines 177 to 185 in a9796b9
|
I figured out a way, just set |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay, that works!
/azp run |
<!--- Provide a general summary of your changes in the Title above --> ## Description The `CopyButton`'s `PointerOver` state is bind to `ButtonPressedForeground` brush, and it will be white in a dark theme, making the button invisible when hoveed in that page. ![image](https://github.com/microsoft/WinUI-Gallery/assets/42881734/d5222c86-c313-4055-a24d-fcf3f78c2d4f) It should be bind to its `Foreground` so it remains invisible. So after this fix: ![image](https://github.com/microsoft/WinUI-Gallery/assets/42881734/a329465e-5b0a-4c73-bbf9-115df7b08eca) ## How Has This Been Tested? Manual ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
<!--- Provide a general summary of your changes in the Title above --> ## Description The `CopyButton`'s `PointerOver` state is bind to `ButtonPressedForeground` brush, and it will be white in a dark theme, making the button invisible when hoveed in that page. ![image](https://github.com/microsoft/WinUI-Gallery/assets/42881734/d5222c86-c313-4055-a24d-fcf3f78c2d4f) It should be bind to its `Foreground` so it remains invisible. So after this fix: ![image](https://github.com/microsoft/WinUI-Gallery/assets/42881734/a329465e-5b0a-4c73-bbf9-115df7b08eca) ## How Has This Been Tested? Manual ## Screenshots (if appropriate): ## Types of changes <!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: --> - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to change)
Description
The
CopyButton
'sPointerOver
state is bind toButtonPressedForeground
brush, and it will be white in a dark theme, making the button invisible when hoveed in that page.It should be bind to its
Foreground
so it remains invisible. So after this fix:Motivation and Context
How Has This Been Tested?
Manual
Screenshots (if appropriate):
Types of changes