Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: A potential bug in Win32WindowHelper.cs #1564

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

Paper-Scallion
Copy link
Contributor

@Paper-Scallion Paper-Scallion commented Jun 15, 2024

Modify the code to avoid potential problems(in 'WinUIGallery/Helper/Win32WindowHelper.cs')

Description

max may have been incorrectly written as min in the code

Motivation and Context

By analyzing the code, it can be inferred that there might be a problem here.

How Has This Been Tested?

Manual test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@Paper-Scallion Paper-Scallion changed the title Update Win32WindowHelper.cs Fix: A potential bug in Win32WindowHelper.cs Jun 18, 2024
@karkarl karkarl requested a review from marcelwgn June 19, 2024 18:23
Copy link
Collaborator

@marcelwgn marcelwgn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good catch, thank you for fixing this!

@karkarl
Copy link
Collaborator

karkarl commented Jul 18, 2024

/azp run

@karkarl karkarl merged commit 116e48b into microsoft:main Jul 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants