Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in NavigationView Sample 5 #1567

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

cfgiugliano
Copy link
Contributor

Description

This fixes a typo in the XAML snippets of NavigationView sample 5

Motivation and Context

This change makes the sample working

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@cfgiugliano
Copy link
Contributor Author

@microsoft-github-policy-service agree

@karkarl
Copy link
Collaborator

karkarl commented Jun 18, 2024

/azp run

@karkarl
Copy link
Collaborator

karkarl commented Jun 18, 2024

Good catch and thanks for the fix!

@karkarl
Copy link
Collaborator

karkarl commented Jun 19, 2024

/azp run

@karkarl karkarl merged commit 5beb75c into microsoft:main Jun 19, 2024
2 checks passed
karkarl pushed a commit that referenced this pull request Jul 15, 2024
<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->
This fixes a typo in the XAML snippets of NavigationView sample 5

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
This change makes the sample working

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
karkarl pushed a commit that referenced this pull request Jul 15, 2024
<!--- Provide a general summary of your changes in the Title above -->

## Description
<!--- Describe your changes in detail -->
This fixes a typo in the XAML snippets of NavigationView sample 5

## Motivation and Context
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
This change makes the sample working

## Types of changes
<!--- What types of changes does your code introduce? Put an `x` in all
the boxes that apply: -->
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing
functionality to change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants