-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating TabView to consume tear-out APIs #1574
base: main
Are you sure you want to change the base?
Conversation
Is it intended to merge into Scott's 1.6 Experimental1 branch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
per Karen, target branch looks like it needs updating
2377d8e
to
5458f50
Compare
Updated to target the main branch instead. |
@@ -1,7 +1,8 @@ | |||
<Project> | |||
<PropertyGroup> | |||
<!-- The NuGet versions of dependencies to build against. --> | |||
<WindowsAppSdkPackageVersion>1.5.240607001</WindowsAppSdkPackageVersion> | |||
<WindowsSdkPackageVersion>10.0.22621.35-preview</WindowsSdkPackageVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can use non-preview 10.0.22621.42
@@ -311,5 +311,10 @@ | |||
<CopyToPublishDirectory>PreserveNewest</CopyToPublishDirectory> | |||
</_NoneWithTargetPath> | |||
</ItemGroup> | |||
</Target> | |||
</Target> | |||
<!-- Needed in order for running unpackaged to work properly. --> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't need this - what assets aren't being copied?
These changes update WinUI Gallery to consume the new TabView tear-out APIs in WASDK experimental 1, instead of using the WinRT drag-and-drop APIs. This makes it so that tab tear-out immediately creates a new window that the user starts to drag, rather than waiting for a drop to create the new window.
While I was here, I also added a change to enable running WinUI Gallery as an unpackaged app, which appeared to previously not be properly functional.