Updating TabView to consume tear-out APIs #1574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is it intended to merge into Scott's 1.6 Experimental1 branch? |
Scottj1s
requested changes
Jul 23, 2024
llongley
force-pushed
the
user/llongley/ConsumingTabTearOut
branch
from
2377d8e
to
5458f50
Compare
|
Updated to target the main branch instead. |
Scottj1s
reviewed
Aug 26, 2024
| @@ -1,7 +1,8 @@ | |||
| <Project> | |||
| <PropertyGroup> | |||
| <!-- The NuGet versions of dependencies to build against. --> | |||
| <WindowsAppSdkPackageVersion>1.5.240607001</WindowsAppSdkPackageVersion> | |||
| <WindowsSdkPackageVersion>10.0.22621.35-preview</WindowsSdkPackageVersion> | |||
There was a problem hiding this comment.
can use non-preview 10.0.22621.42
Scottj1s
reviewed
Aug 26, 2024
| @@ -311,5 +311,10 @@ | |||
| <CopyToPublishDirectory>PreserveNewest</CopyToPublishDirectory> | |||
| </_NoneWithTargetPath> | |||
| </ItemGroup> | |||
| </Target> | |||
| </Target> | |||
| <!-- Needed in order for running unpackaged to work properly. --> | |||
There was a problem hiding this comment.
shouldn't need this - what assets aren't being copied?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes update WinUI Gallery to consume the new TabView tear-out APIs in WASDK experimental 1, instead of using the WinRT drag-and-drop APIs. This makes it so that tab tear-out immediately creates a new window that the user starts to drag, rather than waiting for a drop to create the new window.
While I was here, I also added a change to enable running WinUI Gallery as an unpackaged app, which appeared to previously not be properly functional.