Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide unused scrollbars in RadioButtonsPage #458

Merged
merged 2 commits into from
May 29, 2020

Conversation

marcelwgn
Copy link
Collaborator

Description

Add VerticalScrollBarVibility=Hidden to hide the scrollbars.

Motivation and Context

Closes #455

How Has This Been Tested?

Tested manually

Screenshots (if appropriate):

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@stmoy stmoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A thought: do these even need to be in a scrollviewer at all? I guess "yes" because they could require horizontal scrolling, but double checking.

@marcelwgn
Copy link
Collaborator Author

Yes if the users try to use the app with its minimum width, the scrolling is necessary:

gif

The question, should we show the scrollbars or not? Seems a bit strange that we don't show them, on the other hand, if users disable "auto hide scrollbars" they might seem them all the time while they are not doing anything in 99% of cases.

@stmoy
Copy link
Contributor

stmoy commented May 29, 2020

To simplify the sample, what if we removed the last color option and also deleted the ScrollViewer? The colors aren't the important part of the sample, so maybe we can take a "less is more" approach?

@marcelwgn
Copy link
Collaborator Author

Great idea! Removed the scrollviewer and one color entry for each so we don't need to scroll anymore.

@stmoy stmoy merged commit 354b36e into microsoft:master May 29, 2020
@marcelwgn marcelwgn deleted the radiobuttons-removescrollviewer branch June 18, 2020 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Two groups of radio buttons explicitly grouped by GroupName have scrollbars
2 participants