Prevent crashes on ImplicitAnimation page by checking for NaN #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmoy
reviewed
Jul 1, 2020
| @@ -137,6 +137,15 @@ private void BackgroundButton_Click(object sender, RoutedEventArgs e) | |||
| } | |||
| } | |||
|
|
|||
| private double EnsureValueIsNumber(NumberBox numberBox) | |||
There was a problem hiding this comment.
Could this return a float instead? Then we wouldn't need to cast above.
There was a problem hiding this comment.
Good point, fixed now.
stmoy
approved these changes
Jul 2, 2020
bpulliam
pushed a commit
that referenced
this pull request
Feb 1, 2022
* Prevent crashes on ImplicitAnimation page by checking for NaN * Remove casts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The page crashed when setting the opacity and other values in samples on the page since a cleared NumberBox will report double.NaN as its value which is not a valid value for those cases. This is now fixed by wrapping the "get call" and setting the NumberBox value to 0 if its NaN.
Motivation and Context
Fixes #475
How Has This Been Tested?
Tested manually by clearing the NumberBox values and clicking the "set value buttons" on the samples.
Screenshots (if appropriate):
Types of changes